Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bindings.rabbitmq.com deletion #82

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Support bindings.rabbitmq.com deletion #82

merged 5 commits into from
Mar 24, 2021

Conversation

ChunyiLyu
Copy link
Contributor

This closes #64

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • support bindings.rabbitmq.com deletion. The binding controller supports delete by: 1) when binding.spec.argument is not set, it generates the properties key using binding.spec.routingKey 2) when arguments are set, the controller lists all bindings between a source (an exchange) and a destination (could be a queue or an exchange), and find the corresponding binding's binding info to complete deletion
  • fixed an issue in bindings.rabbitmq.com webhook. binding.spec.arguments is a map, and comparing binding.spec directly with == does not work on map types.
  • refactor test file names in package system_tests/. go test expect test files to have suffix _test. We are not using go test, but aligning with the language naming convention makes it easier for community to contribute.

Additional Context

@ChunyiLyu
binding webhook shouldn't compare binding.spec directly
d5c3710 
- fixed an issue in bindings.rabbitmq.com webhook. binding.spec.arguments is a map.
comparing binding.spec directly with == does not work on map types.
@ChunyiLyu
Add helper GenerateBindingInfo()
4eb332b
@ChunyiLyu
Support bindings.rabbitmq.com deletion
84c0473 
- when binding.spec.argument is not set, it generates
the properties key using binding.spec.routingKey; when
arguments are set, the controller lists all bindings
between a source and a destination, and find the
corresponding binding's binding info to complete deletion
@ChunyiLyu
Go test files should have *_test.go suffix
c0b4d9c 
- go test expect test files to have suffix _test.
We are not using go test, but aligning with the
language naming convention makes it easier for community to contribute
@ChunyiLyu
Remove redundant checks in binding webhook
d6910e8
@ChunyiLyu ChunyiLyu merged commit 9b10d40 into main Mar 24, 2021
@ChunyiLyu ChunyiLyu deleted the binding-delete branch March 24, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirahImage MirahImage MirahImage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete bindings.rabbitmq.com
2 participants
@ChunyiLyu @MirahImage